Netdev List
 help / color / mirror / Atom feed
From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Yuchung Cheng <ycheng@google.com>
Cc: Daniel Metz <dmetz@mytum.de>, netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Neal Cardwell <ncardwell@google.com>,
	Pasi Sarolahti <pasi.sarolahti@iki.fi>,
	Van Jacobson <vanj@google.com>
Subject: Re: [PATCH net-next] tcp: use RFC6298 compliant TCP RTO calculation
Date: Tue, 14 Jun 2016 08:17:03 +0200	[thread overview]
Message-ID: <20160614061703.GA985@virgo.localdomain> (raw)
In-Reply-To: <CAK6E8=cw2JNsqm+1x4dJxmOe2xpt_ywAq3TNtaUv4hOaJL9qiA@mail.gmail.com>

* Yuchung Cheng | 2016-06-13 15:38:24 [-0700]:

Hey Eric, Yuchung,

regarding the missed mdev_max_us: internal communication problem. Daniel well
respin a v2 removing the no longer required mdev_max_us.

>Thanks for the patch. I also have long wanted to evaluate Linux's RTO vs RFC's.
>
>Since this is not a small change, and your patch is only tested on
>emulation-based testbed AFAICT, I'd like to try your patch on Google
>servers to get more data. But this would take a few days to setup &
>collect.

Great - no hurry! We tried hard to find any downsides of RFC 6298 so far
without any result. If you have any special & concrete tests in mind: Daniel
will test it!

>Note that this paper
>https://www.cs.helsinki.fi/research/iwtcp/papers/linuxtcp.pdf has
>detailed rationale of current design (section 4). IMO having a "tight"
>RTO is less necessary now after TLP. I am also testing a new set of
>patches to install a quick reordering timer. But it's worth mentioning
>the paper in the commit message.

We had "difficulties" to find scenarios where the RTO kicks-in. For the
majority of use cases duplicate ACKs triggers TCP retransmission. For bulk
data transmissions almost 100% of retransmissions are triggered by duplicate
ACKs (except connection teardown). TLP will reduce the requirement for RTO
even further, also window probes helps sometimes. The use case we realized was
sender limited, non-continuous flows where a RFC 6298 compliant implementation
is better.

Thank you Yuchung, we will add an reference in v2.

Hagen

  reply	other threads:[~2016-06-14  6:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 20:45 [PATCH net-next] tcp: use RFC6298 compliant TCP RTO calculation Daniel Metz
2016-06-13 21:19 ` Eric Dumazet
2016-06-13 22:38 ` Yuchung Cheng
2016-06-14  6:17   ` Hagen Paul Pfeifer [this message]
2016-06-14 17:58     ` Yuchung Cheng
2016-06-14 19:18       ` [PATCH net-next v2] " Daniel Metz
2016-06-14 21:33         ` Yuchung Cheng
2016-06-15 17:41           ` Hagen Paul Pfeifer
2016-06-15 18:02             ` Yuchung Cheng
2016-06-15 20:34               ` Daniel Metz
2016-06-15 20:38                 ` Eric Dumazet
2016-06-15 21:07                   ` Yuchung Cheng
2016-06-16  9:07                   ` Hagen Paul Pfeifer
2016-06-16  9:03               ` Hagen Paul Pfeifer
2016-06-15 18:00           ` [PATCH net-next v3] " Daniel Metz
2016-06-17 18:32             ` David Miller
2016-06-17 18:56               ` Yuchung Cheng
2016-06-22  5:53                 ` Yuchung Cheng
2016-06-22 11:21                   ` Hagen Paul Pfeifer
2016-06-22 20:50                     ` Yuchung Cheng
2016-06-29  7:06                   ` Yuchung Cheng
2016-06-29 20:18                     ` Daniel Metz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614061703.GA985@virgo.localdomain \
    --to=hagen@jauu.net \
    --cc=dmetz@mytum.de \
    --cc=edumazet@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pasi.sarolahti@iki.fi \
    --cc=vanj@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox