From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Brett Rudley" <brudley@broadcom.com>,
"Arend van Spriel" <arend@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Hante Meuleman" <meuleman@broadcom.com>,
"Pieter-Paul Giesberts" <pieterpg@broadcom.com>,
linux-wireless@vger.kernel.org (open list:BROADCOM BRCM80211
IEEE802.11n WIRELESS DRIVER),
brcm80211-dev-list@broadcom.com (open list:BROADCOM BRCM80211
IEEE802.11n WIRELESS DRIVER),
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [V2, 4.8, 1/2] brcmutil: add field storing control channel to the struct brcmu_chan
Date: Tue, 14 Jun 2016 14:28:19 +0000 (UTC) [thread overview]
Message-ID: <20160614142819.8522261381@smtp.codeaurora.org> (raw)
In-Reply-To: <1463744355-5528-1-git-send-email-zajec5@gmail.com>
Rafał Miłecki wrote:
> Our d11 code supports encoding/decoding channel info into/from chanspec
> format used by firmware. Current implementation is quite misleading
> because of the way "chnum" field is used.
> When encoding channel info, "chnum" has to be filled by a caller with
> *center* channel number. However when decoding chanspec the same field
> is filled with a *control* channel number.
>
> 1) This can be confusing. It's expected for information to be the same
> after encoding and decoding.
> 2) It doesn't allow accessing all info when decoding. Some functions may
> need to know both channel numbers, e.g. cfg80211 callback getting
> current channel.
> Solve this by adding a separated field for control channel.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Thanks, 2 patches applied to wireless-drivers-next.git:
4712d88a5732 brcmutil: add field storing control channel to the struct brcmu_chan
ee6e7aa38394 brcmfmac: support get_channel cfg80211 callback
--
Sent by pwcli
https://patchwork.kernel.org/patch/9129323/
prev parent reply other threads:[~2016-06-14 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 11:02 [PATCH 4.8 1/2] brcmutil: add field storing control channel to the struct brcmu_chan Rafał Miłecki
2016-05-19 11:02 ` [PATCH 4.8 2/2] brcmfmac: support get_channel cfg80211 callback Rafał Miłecki
2016-05-20 7:42 ` Arend Van Spriel
[not found] ` <48f4f8c9-b4a3-66f9-b4a5-640778ac8e79-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-05-20 10:54 ` Rafał Miłecki
2016-05-20 7:52 ` [PATCH 4.8 1/2] brcmutil: add field storing control channel to the struct brcmu_chan Arend Van Spriel
2016-05-20 11:38 ` [PATCH V2 " Rafał Miłecki
[not found] ` <1463744355-5528-1-git-send-email-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-20 11:38 ` [PATCH V2 4.8 2/2] brcmfmac: support get_channel cfg80211 callback Rafał Miłecki
2016-06-14 14:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614142819.8522261381@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).