From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: libertas: Remove create_workqueue Date: Thu, 16 Jun 2016 15:22:46 +0000 (UTC) Message-ID: <20160616152246.B3B6E61457@smtp.codeaurora.org> References: <20160604135901.GA29897@Karyakshetra> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Andreas Kemnade , Dan Carpenter , Bhaktipriya Shridhar , "Andrew F. Davis" , Jonathan Cameron , Mark Brown , Tejun Heo , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Bhaktipriya Shridhar Return-path: In-Reply-To: <20160604135901.GA29897@Karyakshetra> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > In if_sdio.c, the workqueue card->workqueue has workitem > &card->packet_worker, which is mapped to if_sdio_host_to_card_worker. > The workitem is involved in sending packets to firmware. > Forward progress under memory pressure is a requirement here. > > In if_spi.c, the workqueue card->workqueue has workitem > &card->packet_worker, which is mapped to if_spi_host_to_card_worker. > The workitem is involved in sending command packets from the host. > Forward progress under memory pressure is a requirement here. > > Dedicated workqueues have been used in both cases since the workitems > on the workqueues are involved in normal device operation with > WQ_MEM_RECLAIM set to gurantee forward progress under memory pressure. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary. > > flush_workqueue is unnecessary since destroy_workqueue() itself calls > drain_workqueue() which flushes repeatedly till the workqueue > becomes empty. Hence the calls to flush_workqueue() before > destroy_workqueue() have been dropped. > > Signed-off-by: Bhaktipriya Shridhar > Acked-by: Tejun Heo Thanks, 1 patch applied to wireless-drivers-next.git: f9f905b00b87 libertas: Remove create_workqueue -- Sent by pwcli https://patchwork.kernel.org/patch/9154703/