From: Andrew Lunn <andrew@lunn.ch>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0
Date: Thu, 16 Jun 2016 18:33:36 +0200 [thread overview]
Message-ID: <20160616163336.GD28432@lunn.ch> (raw)
In-Reply-To: <1466092470-20958-1-git-send-email-jeremy.linton@arm.com>
On Thu, Jun 16, 2016 at 10:54:30AM -0500, Jeremy Linton wrote:
> By default, mdiobus_alloc() sets the PHY's to polling mode, but a
> pointer size memcpy means that couple IRQs (depending
> on 32-bit or 64-bit kernels) end up being overwritten with
> a value of 0. This means that PHY_POLL is disabled and results
> in unpredictable behavior depending on the PHYs location on the mdio
> bus. Remove that memcpy and the now unused phy_irq member to force
> SMSC911x PHY's into polling mode 100% of the time.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2016-06-16 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 15:54 [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0 Jeremy Linton
2016-06-16 16:33 ` Andrew Lunn [this message]
2016-06-16 18:55 ` Sergei Shtylyov
2016-06-16 19:53 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616163336.GD28432@lunn.ch \
--to=andrew@lunn.ch \
--cc=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).