* [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP
@ 2016-06-17 20:12 Sowmini Varadhan
2016-06-17 20:51 ` Santosh Shilimkar
2016-06-18 5:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sowmini Varadhan @ 2016-06-17 20:12 UTC (permalink / raw)
To: netdev; +Cc: sowmini.varadhan, davem, santosh.shilimkar
The state of the rds_connection after rds_tcp_reset_callbacks() would
be RDS_CONN_RESETTING and this is the value that should be passed
by rds_tcp_accept_one() to rds_connect_path_complete() to transition
the socket to RDS_CONN_UP.
Fixes: b5c21c0947c1 ("RDS: TCP: fix race windows in send-path quiescence
by rds_tcp_accept_one()")
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
---
net/rds/tcp_listen.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c
index 686b1d0..245542c 100644
--- a/net/rds/tcp_listen.c
+++ b/net/rds/tcp_listen.c
@@ -138,7 +138,7 @@ int rds_tcp_accept_one(struct socket *sock)
rds_tcp_reset_callbacks(new_sock, conn);
conn->c_outgoing = 0;
/* rds_connect_path_complete() marks RDS_CONN_UP */
- rds_connect_path_complete(conn, RDS_CONN_DISCONNECTING);
+ rds_connect_path_complete(conn, RDS_CONN_RESETTING);
}
} else {
rds_tcp_set_callbacks(new_sock, conn);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP
2016-06-17 20:12 [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP Sowmini Varadhan
@ 2016-06-17 20:51 ` Santosh Shilimkar
2016-06-18 5:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2016-06-17 20:51 UTC (permalink / raw)
To: Sowmini Varadhan, netdev; +Cc: davem
On 6/17/2016 1:12 PM, Sowmini Varadhan wrote:
> The state of the rds_connection after rds_tcp_reset_callbacks() would
> be RDS_CONN_RESETTING and this is the value that should be passed
> by rds_tcp_accept_one() to rds_connect_path_complete() to transition
> the socket to RDS_CONN_UP.
>
> Fixes: b5c21c0947c1 ("RDS: TCP: fix race windows in send-path quiescence
> by rds_tcp_accept_one()")
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP
2016-06-17 20:12 [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP Sowmini Varadhan
2016-06-17 20:51 ` Santosh Shilimkar
@ 2016-06-18 5:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-06-18 5:30 UTC (permalink / raw)
To: sowmini.varadhan; +Cc: netdev, santosh.shilimkar
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Fri, 17 Jun 2016 16:12:12 -0400
> The state of the rds_connection after rds_tcp_reset_callbacks() would
> be RDS_CONN_RESETTING and this is the value that should be passed
> by rds_tcp_accept_one() to rds_connect_path_complete() to transition
> the socket to RDS_CONN_UP.
>
> Fixes: b5c21c0947c1 ("RDS: TCP: fix race windows in send-path quiescence
> by rds_tcp_accept_one()")
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-18 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 20:12 [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP Sowmini Varadhan
2016-06-17 20:51 ` Santosh Shilimkar
2016-06-18 5:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).