* [patch 1/3 -next] liquidio: a couple indenting tweaks
@ 2016-06-18 8:49 Dan Carpenter
2016-06-22 20:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-06-18 8:49 UTC (permalink / raw)
To: Derek Chickles
Cc: Satanand Burla, Felix Manlunas, Raghu Vatsavayi, netdev,
kernel-janitors
Remove a stray space character and fix an if statement that wasn't
indented.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Speaking of style issues, this whole file follows return 1 on error
and 0 on success. It was confusing for me. It's not too late to change
it to use correct error codes. ;)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index d0ab97c..715ddfa 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -365,7 +365,7 @@ static int wait_for_pending_requests(struct octeon_device *oct)
[OCTEON_ORDERED_SC_LIST].pending_req_count);
if (pcount)
schedule_timeout_uninterruptible(HZ / 10);
- else
+ else
break;
}
@@ -3351,8 +3351,8 @@ static int setup_nic_devices(struct octeon_device *octeon_dev)
liquidio_set_ethtool_ops(netdev);
if (netdev->features & NETIF_F_LRO)
- liquidio_set_feature(netdev, OCTNET_CMD_LRO_ENABLE,
- OCTNIC_LROIPV4 | OCTNIC_LROIPV6);
+ liquidio_set_feature(netdev, OCTNET_CMD_LRO_ENABLE,
+ OCTNIC_LROIPV4 | OCTNIC_LROIPV6);
if ((debug != -1) && (debug & NETIF_MSG_HW))
liquidio_set_feature(netdev, OCTNET_CMD_VERBOSE_ENABLE,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 1/3 -next] liquidio: a couple indenting tweaks
2016-06-18 8:49 [patch 1/3 -next] liquidio: a couple indenting tweaks Dan Carpenter
@ 2016-06-22 20:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-22 20:21 UTC (permalink / raw)
To: dan.carpenter
Cc: derek.chickles, satananda.burla, felix.manlunas, raghu.vatsavayi,
netdev, kernel-janitors
Dan, please don't mix bug fixes and cleanups in the same patch
series.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-22 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-18 8:49 [patch 1/3 -next] liquidio: a couple indenting tweaks Dan Carpenter
2016-06-22 20:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).