From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v3 net-next v3 10/14] net: dsa: mv88e6xxx: add SMI init helper Date: Sat, 18 Jun 2016 22:25:44 +0200 Message-ID: <20160618202544.GE7172@lunn.ch> References: <20160618000736.5598-1-vivien.didelot@savoirfairelinux.com> <20160618000736.5598-11-vivien.didelot@savoirfairelinux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Ben Dooks , Sergei Shtylyov To: Vivien Didelot Return-path: Content-Disposition: inline In-Reply-To: <20160618000736.5598-11-vivien.didelot@savoirfairelinux.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Jun 17, 2016 at 08:07:32PM -0400, Vivien Didelot wrote: > Add an helper function to isolate SMI specific assignations and checks. I don't think you meant assignations. Assignments? Otherwise Reviewed-by: Andrew Lunn Andrew