netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	netdev@vger.kernel.org, f.fainelli@gmail.com, johan@kernel.org,
	bth@kamstrup.dk
Subject: Re: Micrel Phy KSZ8031 clock select setting in dts
Date: Mon, 20 Jun 2016 14:45:39 +0200	[thread overview]
Message-ID: <20160620124539.GB20362@lunn.ch> (raw)
In-Reply-To: <20160620120821.GA19639@graute-opti>

> &fec1 {
> 	pinctrl-names = "default";
> 	pinctrl-0 = <&pinctrl_enet1>;
> 	phy-mode = "rmii";
> 	micrel,rmii-reference-clock-select-25-mhz;
> 	clocks,rmii-ref;

You are adding phy properties, not MAC properties. Please put them in
the phy node.

    Andrew

  reply	other threads:[~2016-06-20 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 13:04 Micrel Phy KSZ8031 clock select setting in dts Oliver Graute
2016-06-17 13:48 ` Sergei Shtylyov
2016-06-19 19:29   ` Oliver Graute
2016-06-20  6:21     ` Sascha Hauer
2016-06-20 12:08       ` Oliver Graute
2016-06-20 12:45         ` Andrew Lunn [this message]
2016-06-20 17:14           ` Oliver Graute
2016-06-21  6:16             ` Sascha Hauer
2016-06-22  8:18               ` Oliver Graute
2016-06-20 12:56         ` Sergei Shtylyov
2016-06-20 13:12           ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620124539.GB20362@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bth@kamstrup.dk \
    --cc=f.fainelli@gmail.com \
    --cc=johan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).