From: David Miller <davem@davemloft.net>
To: ab@abahmed.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Fix resetting network_header in neigh_resolve_output and neigh_connected_output
Date: Mon, 27 Jun 2016 10:10:32 -0400 (EDT) [thread overview]
Message-ID: <20160627.101032.719251971537230839.davem@davemloft.net> (raw)
In-Reply-To: <1557d0eb9b5.10e107ce3332041.1418466288700186568@abahmed.com>
From: Abdelrhman Ahmed <ab@abahmed.com>
Date: Thu, 23 Jun 2016 13:39:24 +0200
> neigh_resolve_output and neigh_connected_output resets the skb to network_header because of the retry loop and this reset will pull down the data pointer to the network header in the first iteration then hardware header will be added, but it will overwrite any data which is inserted between network header and hardware header (for example by netfilter hooks) only for the first packet(s) before using cached hardware header as neigh_hh_output (which is called for using cached hardware header) does not reset to the network header.
Please format your text properly into ~80 character long lines.
next prev parent reply other threads:[~2016-06-27 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 11:39 [PATCH] net: Fix resetting network_header in neigh_resolve_output and neigh_connected_output Abdelrhman Ahmed
2016-06-27 14:10 ` David Miller [this message]
2016-06-27 14:28 ` Abdelrhman Ahmed
2016-07-01 19:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627.101032.719251971537230839.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ab@abahmed.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).