From: Tobias Klauser <tklauser@distanz.ch>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: davem@davemloft.net, andrew@lunn.ch, colin.king@canonical.com,
f.fainelli@gmail.com, jcmvbkbc@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device
Date: Mon, 27 Jun 2016 08:32:59 +0200 [thread overview]
Message-ID: <20160627063258.GH28466@distanz.ch> (raw)
In-Reply-To: <1466865222-11840-1-git-send-email-tremyfr@gmail.com>
On 2016-06-25 at 16:33:41 +0200, Philippe Reynes <tremyfr@gmail.com> wrote:
> The private structure contain a pointer to phydev, but the structure
> net_device already contain such pointer. So we can remove the pointer
> phy in the private structure, and update the driver to use the
> one contained in struct net_device.
In that case the phy member should also be removed from the definition
of private struct ethoc in the same patch.
Otherwise the patch looks good to me.
prev parent reply other threads:[~2016-06-27 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 14:33 [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device Philippe Reynes
2016-06-25 14:33 ` [PATCH 2/2] net: ethernet: ethoc: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-06-27 6:35 ` Tobias Klauser
2016-06-25 18:31 ` [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device Max Filippov
2016-06-27 6:32 ` Tobias Klauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627063258.GH28466@distanz.ch \
--to=tklauser@distanz.ch \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).