From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/3] ss: Refactor inet_show_sock
Date: Mon, 27 Jun 2016 11:06:55 -0700 [thread overview]
Message-ID: <20160627110655.474ef337@xeon-e3> (raw)
In-Reply-To: <1466566706-1511-2-git-send-email-dsa@cumulusnetworks.com>
On Tue, 21 Jun 2016 20:38:24 -0700
David Ahern <dsa@cumulusnetworks.com> wrote:
> Extract parsing of sockstat and filter from inet_show_sock.
> While moving run_ssfilter into callers of inet_show_sock enable
> userspace filtering before the kill.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
I would add this but it has checkpatch style issues
WARNING: braces {} are not necessary for any arm of this statement
#65: FILE: misc/ss.c:2060:
+ if (s->local.family == AF_INET) {
[...]
} else {
[...]
WARNING: line over 80 characters
#80: FILE: misc/ss.c:2070:
+static int inet_show_sock(struct nlmsghdr *nlh, struct sockstat *s, int protocol)
ERROR: do not use assignment in if condition
#129: FILE: misc/ss.c:2295:
+ if ((err = inet_show_sock(h, &s, diag_arg->protocol)) < 0)
next prev parent reply other threads:[~2016-06-27 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 3:38 [PATCH iproute2 0/3] ss: Add support to filter by device David Ahern
2016-06-22 3:38 ` [PATCH iproute2 1/3] ss: Refactor inet_show_sock David Ahern
2016-06-27 18:06 ` Stephen Hemminger [this message]
2016-06-22 3:38 ` [PATCH iproute2 2/3] ss: Allow ssfilter_bytecompile to return 0 David Ahern
2016-06-22 3:38 ` [PATCH iproute2 3/3] ss: Add support to filter on device David Ahern
2016-06-27 18:09 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627110655.474ef337@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).