From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 3/3] ss: Add support to filter on device
Date: Mon, 27 Jun 2016 11:09:21 -0700 [thread overview]
Message-ID: <20160627110921.7ae95e63@xeon-e3> (raw)
In-Reply-To: <1466566706-1511-4-git-send-email-dsa@cumulusnetworks.com>
On Tue, 21 Jun 2016 20:38:26 -0700
David Ahern <dsa@cumulusnetworks.com> wrote:
> Add support for device names in the filter. Example:
>
> root@kenny:~# ss -t 'sport == :22 && dev == red'
> State Recv-Q Send-Q Local Address:Port Peer Address:Port
> ESTAB 0 0 10.100.1.2%red:ssh 10.100.1.254:47814
> ESTAB 0 0 2100:1::2%red:ssh 2100:1::64:49406
>
> Since kernel does not support iface in the filter specifying a
> device name means all filtering is done in userspace.
>
Introduces new checkpatch whitespace issues.
ERROR: code indent should use tabs where possible
#60: FILE: misc/ss.c:1337:
+ case SSF_DEVCOND:$
WARNING: please, no spaces at the start of a line
#60: FILE: misc/ss.c:1337:
+ case SSF_DEVCOND:$
ERROR: code indent should use tabs where possible
#63: FILE: misc/ss.c:1340:
+ return 0;$
WARNING: please, no spaces at the start of a line
#63: FILE: misc/ss.c:1340:
+ return 0;$
prev parent reply other threads:[~2016-06-27 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 3:38 [PATCH iproute2 0/3] ss: Add support to filter by device David Ahern
2016-06-22 3:38 ` [PATCH iproute2 1/3] ss: Refactor inet_show_sock David Ahern
2016-06-27 18:06 ` Stephen Hemminger
2016-06-22 3:38 ` [PATCH iproute2 2/3] ss: Allow ssfilter_bytecompile to return 0 David Ahern
2016-06-22 3:38 ` [PATCH iproute2 3/3] ss: Add support to filter on device David Ahern
2016-06-27 18:09 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627110921.7ae95e63@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox