From: Bob Copeland <me@bobcopeland.com>
To: Yaniv Machani <yanivma@ti.com>
Cc: linux-kernel@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
"David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Meirav Kama <meiravk@ti.com>
Subject: Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template
Date: Tue, 28 Jun 2016 10:06:26 -0400 [thread overview]
Message-ID: <20160628140625.GC9984@localhost> (raw)
In-Reply-To: <20160628111307.8784-4-yanivma@ti.com>
On Tue, Jun 28, 2016 at 02:13:06PM +0300, Yaniv Machani wrote:
> From: Meirav Kama <meiravk@ti.com>
>
> There are several values in HT info elements of mesh beacon (built by the
> mac80211) that are incorrect.
Would be good to enumerate the problems here.
> To fix them:
> 1. mac80211 will check configuration from cfg and will build accordingly.
> 2. changes made in mesh default values.
What is wrong with the defaults?
> sband = local->hw.wiphy->bands[band];
> if (!sband->ht_cap.ht_supported ||
> @@ -431,11 +433,40 @@ int mesh_add_ht_cap_ie(struct ieee80211_sub_if_data *sdata,
> sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10)
> return 0;
>
> + /* determine capability flags */
> + cap = sband->ht_cap.cap;
There is some weird whitespace here (space instead of tabs for the
comment).
--
Bob Copeland %% http://bobcopeland.com/
next prev parent reply other threads:[~2016-06-28 14:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 11:13 [PATCH 0/4] Mesh mpm fixes and enhancements Yaniv Machani
2016-06-28 11:13 ` [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped Yaniv Machani
2016-06-28 11:13 ` [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting Yaniv Machani
2016-06-28 11:13 ` [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template Yaniv Machani
2016-06-28 11:13 ` [PATCH 4/4] mac80211: sta_info: max_peers reached falsely Yaniv Machani
2016-06-28 12:56 ` Bob Copeland
2016-06-28 13:05 ` Machani, Yaniv
2016-06-28 14:06 ` Bob Copeland [this message]
[not found] ` <20160628111307.8784-4-yanivma-l0cyMroinI0@public.gmane.org>
2016-06-29 7:17 ` [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template Johannes Berg
[not found] ` <1467184655.2461.2.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-07-13 11:15 ` Machani, Yaniv
[not found] ` <20160628111307.8784-3-yanivma-l0cyMroinI0@public.gmane.org>
2016-06-28 12:27 ` [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting Bob Copeland
2016-06-28 14:43 ` Machani, Yaniv
2016-06-29 7:14 ` [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped Johannes Berg
[not found] ` <1467184459.2461.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-07-13 10:11 ` Machani, Yaniv
2016-07-13 13:33 ` Bob Copeland
2016-07-13 19:54 ` Machani, Yaniv
2016-08-01 9:38 ` Johannes Berg
2016-06-29 4:43 ` [PATCH 0/4] Mesh mpm fixes and enhancements Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628140625.GC9984@localhost \
--to=me@bobcopeland.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meiravk@ti.com \
--cc=netdev@vger.kernel.org \
--cc=yanivma@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).