From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 iproute2 0/6] Add support for vrf keyword
Date: Wed, 29 Jun 2016 08:07:40 -0700 [thread overview]
Message-ID: <20160629080740.198843fe@xeon-e3> (raw)
In-Reply-To: <1467053461-16147-1-git-send-email-dsa@cumulusnetworks.com>
On Mon, 27 Jun 2016 11:50:55 -0700
David Ahern <dsa@cumulusnetworks.com> wrote:
> Currently the syntax for VRF related commands is rather kludgy and
> inconsistent from one subcommand to another. This set adds support
> for the VRF keyword to the link, address, neigh, and route commands
> to improve the user experience listing data associated with vrfs,
> modifying routes or doing a route lookup.
>
> v2
> - rebased to top of tree
> - all checkpatch warnings are usage lines. The change in these
> patches is consistent with existing code for usage lines
Does this break current user scripts?
It seems this method will cause lots of additional netlink requests
to check if device is a vrf. Won't this impact users with 1000's of devices?
next prev parent reply other threads:[~2016-06-29 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 18:50 [PATCH v2 iproute2 0/6] Add support for vrf keyword David Ahern
2016-06-27 18:50 ` [PATCH iproute2 1/6] ip vrf: Add name_is_vrf David Ahern
2016-06-29 15:06 ` Stephen Hemminger
2016-06-29 16:57 ` David Ahern
2016-06-27 18:50 ` [PATCH v2 iproute2 2/6] ip link/addr: Add support for vrf keyword David Ahern
2016-06-27 18:50 ` [PATCH iproute2 3/6] ip neigh: Add support for keyword David Ahern
2016-06-27 18:50 ` [PATCH iproute2 4/6] ip route: Change type mask to bitmask David Ahern
2016-06-27 18:51 ` [PATCH iproute2 5/6] ip vrf: Add ipvrf_get_table David Ahern
2016-06-27 18:51 ` [PATCH iproute2 6/6] ip route: Add support for vrf keyword David Ahern
2016-06-29 15:07 ` Stephen Hemminger [this message]
2016-06-29 17:06 ` [PATCH v2 iproute2 0/6] " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629080740.198843fe@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox