public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemming@brocade.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: Andrey Vagin <avagin@openvz.org>,
	Hannes Frederic Sowa <hannes@stressinduktion.org>,
	network dev <netdev@vger.kernel.org>,
	"Andrew Vagin" <avagin@virtuozzo.com>,
	Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH] ip route: timeout for routes has to be set in seconds
Date: Wed, 29 Jun 2016 09:25:22 -0700	[thread overview]
Message-ID: <20160629092522.494bd502@xeon-e3> (raw)
In-Reply-To: <15a8916ec54d447b95cff28f99118342@HQ1WP-EXMB11.corp.brocade.com>


> There's another issue.
> now  the expires transition with HZ happens in kernel when we add
> route with expire, but when we dump,  the expires transition is in the
> user-space:
>                         if (ci->rta_expires != 0)
>                                 fprintf(fp, " expires %dsec",
> ci->rta_expires/hz);
> 
> I'm not sure if  the *hz* value between kernel and user-space are
> always same. I'd like to do this transition both in kernel. just like
> ipaddr's
> valid_lft, preferred_lft.

All API's from applications are supposed to use USER_HZ which is 100hz
on most platforms. Actual kernel internal hz is configurable.

There were some cases legacy of early days where iproute2 had to deal
with kernel hz, mostly in the QoS stuff.

  parent reply	other threads:[~2016-06-29 16:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 23:27 [PATCH] ip route: timeout for routes has to be set in seconds Andrey Vagin
2016-06-29 10:26 ` Xin Long
     [not found] ` <15a8916ec54d447b95cff28f99118342@HQ1WP-EXMB11.corp.brocade.com>
2016-06-29 16:25   ` Stephen Hemminger [this message]
     [not found] <5a205385ce594320936c4e330d52f532@HQ1WP-EXMB11.corp.brocade.com>
2016-07-01  0:29 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160629092522.494bd502@xeon-e3 \
    --to=shemming@brocade.com \
    --cc=avagin@openvz.org \
    --cc=avagin@virtuozzo.com \
    --cc=hannes@stressinduktion.org \
    --cc=liuhangbin@gmail.com \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox