* [patch] be2net: signedness bug in be_msix_enable()
@ 2016-06-29 14:39 Dan Carpenter
2016-06-30 11:22 ` Sathya Perla
2016-06-30 12:56 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-06-29 14:39 UTC (permalink / raw)
To: Sathya Perla
Cc: Ajit Khaparde, Sriharsha Basavapatna, Somnath Kotur, netdev,
kernel-janitors
"num_vec" needs to be signed for the error handling to work.
Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 1873c74..1f16e73 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter *adapter)
static int be_msix_enable(struct be_adapter *adapter)
{
- unsigned int i, num_vec, max_roce_eqs;
+ unsigned int i, max_roce_eqs;
struct device *dev = &adapter->pdev->dev;
+ int num_vec;
/* If RoCE is supported, program the max number of vectors that
* could be used for NIC and RoCE, else, just program the number
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [patch] be2net: signedness bug in be_msix_enable()
2016-06-29 14:39 [patch] be2net: signedness bug in be_msix_enable() Dan Carpenter
@ 2016-06-30 11:22 ` Sathya Perla
2016-06-30 12:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sathya Perla @ 2016-06-30 11:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ajit Kumar Khaparde, Sriharsha Basavapatna, Somnath Kotur, netdev,
kernel-janitors
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>
> "num_vec" needs to be signed for the error handling to work.
>
> Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
> index 1873c74..1f16e73 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter
*adapter)
>
> static int be_msix_enable(struct be_adapter *adapter) {
> - unsigned int i, num_vec, max_roce_eqs;
> + unsigned int i, max_roce_eqs;
> struct device *dev = &adapter->pdev->dev;
> + int num_vec;
>
Oops...thanks for catching this! This must go into net-next.
Acked-by: Sathya Perla <sathya.perla@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] be2net: signedness bug in be_msix_enable()
2016-06-29 14:39 [patch] be2net: signedness bug in be_msix_enable() Dan Carpenter
2016-06-30 11:22 ` Sathya Perla
@ 2016-06-30 12:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-06-30 12:56 UTC (permalink / raw)
To: dan.carpenter
Cc: sathya.perla, ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 29 Jun 2016 17:39:43 +0300
> "num_vec" needs to be signed for the error handling to work.
>
> Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-30 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-29 14:39 [patch] be2net: signedness bug in be_msix_enable() Dan Carpenter
2016-06-30 11:22 ` Sathya Perla
2016-06-30 12:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).