* [PATCH] wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq
@ 2016-06-10 0:46 Bruno Herrera
[not found] ` <1465519606-68129-1-git-send-email-bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Bruno Herrera @ 2016-06-10 0:46 UTC (permalink / raw)
To: kvalo; +Cc: poggi.raph, linux-wireless, netdev, linux-kernel
pdev_data pointer is being freed with kfree but the pointer is not dynamic allocated.
Signed-off-by: Bruno Herrera <bruherrera@gmail.com>
---
drivers/net/wireless/ti/wlcore/sdio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index c172da5..5839acb 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -241,7 +241,6 @@ static int wlcore_probe_of(struct device *dev, int *irq,
*irq = irq_of_parse_and_map(np, 0);
if (!*irq) {
dev_err(dev, "No irq in platform data\n");
- kfree(pdev_data);
return -EINVAL;
}
--
2.7.4 (Apple Git-66)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq
[not found] ` <1465519606-68129-1-git-send-email-bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-06-29 15:46 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-06-29 15:46 UTC (permalink / raw)
To: Bruno Herrera
Cc: poggi.raph-Re5JQEeQqe8AvxtiuMwx3w,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Bruno Herrera <bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> pdev_data pointer is being freed with kfree but the pointer is not dynamic allocated.
>
> Signed-off-by: Bruno Herrera <bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Thanks, 1 patch applied to wireless-drivers-next.git:
6edc119ed3b5 wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq
--
Sent by pwcli
https://patchwork.kernel.org/patch/9168709/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-29 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-10 0:46 [PATCH] wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq Bruno Herrera
[not found] ` <1465519606-68129-1-git-send-email-bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-29 15:46 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).