From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [REBASED] brcmfmac: fix lockup when removing P2P interface after event timeout Date: Wed, 29 Jun 2016 15:57:57 +0000 (UTC) Message-ID: <20160629155757.4250E61372@smtp.codeaurora.org> References: <1466159371-19968-1-git-send-email-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , "Franky (Zhenhui) Lin" , Johannes Berg , linux-wireless@vger.kernel.org (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), brcm80211-dev-list.pdl@broadcom.com (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40430 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbcF2P6j (ORCPT ); Wed, 29 Jun 2016 11:58:39 -0400 In-Reply-To: <1466159371-19968-1-git-send-email-zajec5@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Rafa=C5=82 Mi=C5=82ecki wrote: > Removing P2P interface is handled by sending a proper request to the > firmware. On success firmware triggers an event and driver's handler > removes a matching interface. >=20 > However on event timeout we remove interface directly from the cfg802= 11 > callback. Current code doesn't handle this case correctly as it alway= s > assumes rtnl to be unlocked. >=20 > Fix it by adding an extra rtnl_locked parameter to functions and call= ing > unregister_netdevice when needed. >=20 > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki Thanks, 1 patch applied to wireless-drivers-next.git: b50ddfa8530e brcmfmac: fix lockup when removing P2P interface after eve= nt timeout --=20 Sent by pwcli https://patchwork.kernel.org/patch/9183337/