netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH 1/2] ip-address: Support filtering by slave type, too
Date: Wed, 29 Jun 2016 17:11:41 -0700	[thread overview]
Message-ID: <20160629171141.62b44c1f@xeon-e3> (raw)
In-Reply-To: <1467119237-12544-2-git-send-email-phil@nwl.cc>

On Tue, 28 Jun 2016 15:07:16 +0200
Phil Sutter <phil@nwl.cc> wrote:

> +static int match_link_kind(struct rtattr **tb, char *kind, bool slave)

const char *kind ??

> +{
> +	if (!tb[IFLA_LINKINFO])
> +		return -1;
> +
> +	return strcmp(parse_link_kind(tb[IFLA_LINKINFO], slave), kind);
> +}
> +

  parent reply	other threads:[~2016-06-30  0:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 13:07 [iproute PATCH 0/2] ip-address: fix type list inconsistencies Phil Sutter
2016-06-28 13:07 ` [iproute PATCH 1/2] ip-address: Support filtering by slave type, too Phil Sutter
2016-06-29  1:19   ` David Ahern
2016-06-30  0:11   ` Stephen Hemminger [this message]
2016-06-30 14:47     ` [iproute PATCH] ip-address: constify match_link_kind arg Phil Sutter
2016-06-28 13:07 ` [iproute PATCH 2/2] ip-address: Align type list in help and man page Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160629171141.62b44c1f@xeon-e3 \
    --to=shemming@brocade.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).