From: Hariprasad Shenai <hariprasad@chelsio.com>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>
Cc: David Miller <davem@davemloft.net>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
netdev <netdev@vger.kernel.org>,
"leedom@chelsio.com" <leedom@chelsio.com>,
"nirranjan@chelsio.com" <nirranjan@chelsio.com>,
"kumaras@chelsio.com" <kumaras@chelsio.com>
Subject: Re: [PATCH net-next 2/3] cxgb4/cxgb4vf: Add set VF mac address support
Date: Thu, 30 Jun 2016 20:45:11 +0530 [thread overview]
Message-ID: <20160630151510.GA20137@hari-Latitude-E5550> (raw)
In-Reply-To: <CO2PR11MB00888D6B7361F0F7ECCF861597240@CO2PR11MB0088.namprd11.prod.outlook.com>
On Thu, Jun 30, 2016 at 13:13:15 +0000, Yuval Mintz wrote:
> > + /* verify MAC addr is valid */
> > + if (!is_zero_ether_addr(mac) && !is_valid_ether_addr(mac) &&
> > + is_multicast_ether_addr(mac)) {
>
> This is really odd as verification goes; Currently this is a very elaborate
> way of checking for multicast, but I guess it's probably a mistake.
>
My bad, will send a V2
next prev parent reply other threads:[~2016-06-30 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 11:00 [PATCH net-next 0/3] Add option to specify PF parameter for IFLA_VF_MAC Hariprasad Shenai
2016-06-30 11:00 ` [PATCH net-next 1/3] net: Add provision to specify pf number while assigning VF mac Hariprasad Shenai
2016-06-30 11:00 ` [PATCH net-next 2/3] cxgb4/cxgb4vf: Add set VF mac address support Hariprasad Shenai
2016-06-30 13:13 ` Yuval Mintz
2016-06-30 15:15 ` Hariprasad Shenai [this message]
2016-06-30 11:00 ` [PATCH net-next iproute2 3/3] ip: Add option to specify PF number associated with the VF Hariprasad Shenai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630151510.GA20137@hari-Latitude-E5550 \
--to=hariprasad@chelsio.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=davem@davemloft.net \
--cc=kumaras@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox