From: David Miller <davem@davemloft.net>
To: richard.alpe@ericsson.com
Cc: netdev@vger.kernel.org, kjlu@gatech.edu,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next] tipc: fix nl compat regression for link statistics
Date: Fri, 01 Jul 2016 16:49:23 -0400 (EDT) [thread overview]
Message-ID: <20160701.164923.904503664300140834.davem@davemloft.net> (raw)
In-Reply-To: <1467364281-20251-1-git-send-email-richard.alpe@ericsson.com>
From: Richard Alpe <richard.alpe@ericsson.com>
Date: Fri, 1 Jul 2016 11:11:21 +0200
> Fix incorrect use of nla_strlcpy() where the first NLA_HDRLEN bytes
> of the link name where left out.
>
> Making the output of tipc-config -ls look something like:
> Link statistics:
> dcast-link
> 1:data0-1.1.2:data0
> 1:data0-1.1.3:data0
>
> Also, for the record, the patch that introduce this regression
> claims "Sending the whole object out can cause a leak". Which isn't
> very likely as this is a compat layer, where the data we are parsing
> is generated by us and we know the string to be NULL terminated. But
> you can of course never be to secure.
>
> Fixes: 5d2be1422e02 (tipc: fix an infoleak in tipc_nl_compat_link_dump)
> Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Applied to 'net' since that is where the regression exists.
Please submit bug fixes to the correct tree.
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
prev parent reply other threads:[~2016-07-01 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 9:11 [PATCH net-next] tipc: fix nl compat regression for link statistics Richard Alpe
2016-07-01 20:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701.164923.904503664300140834.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kjlu@gatech.edu \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).