From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] tipc: fix nl compat regression for link statistics Date: Fri, 01 Jul 2016 16:49:23 -0400 (EDT) Message-ID: <20160701.164923.904503664300140834.davem@davemloft.net> References: <1467364281-20251-1-git-send-email-richard.alpe@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kjlu@gatech.edu, tipc-discussion@lists.sourceforge.net To: richard.alpe@ericsson.com Return-path: In-Reply-To: <1467364281-20251-1-git-send-email-richard.alpe@ericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tipc-discussion-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org From: Richard Alpe Date: Fri, 1 Jul 2016 11:11:21 +0200 > Fix incorrect use of nla_strlcpy() where the first NLA_HDRLEN bytes > of the link name where left out. > > Making the output of tipc-config -ls look something like: > Link statistics: > dcast-link > 1:data0-1.1.2:data0 > 1:data0-1.1.3:data0 > > Also, for the record, the patch that introduce this regression > claims "Sending the whole object out can cause a leak". Which isn't > very likely as this is a compat layer, where the data we are parsing > is generated by us and we know the string to be NULL terminated. But > you can of course never be to secure. > > Fixes: 5d2be1422e02 (tipc: fix an infoleak in tipc_nl_compat_link_dump) > Signed-off-by: Richard Alpe Applied to 'net' since that is where the regression exists. Please submit bug fixes to the correct tree. ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape