From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hariprasad Shenai Subject: Re: [PATCHv2 net-next 1/3] net: Add provision to specify pf number while assigning VF mac Date: Fri, 1 Jul 2016 08:40:56 +0530 Message-ID: <20160701031055.GA29804@hari-Latitude-E5550> References: <1467300884-32340-1-git-send-email-hariprasad@chelsio.com> <1467300884-32340-2-git-send-email-hariprasad@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , "stephen@networkplumber.org" , netdev , "nirranjan@chelsio.com" , "leedom@chelsio.com" , "kumaras@chelsio.com" To: Yuval Mintz Return-path: Received: from [12.32.117.8] ([12.32.117.8]:61673 "EHLO stargate3.asicdesigners.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751969AbcGADNR (ORCPT ); Thu, 30 Jun 2016 23:13:17 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jun 30, 2016 at 19:04:16 +0000, Yuval Mintz wrote: > > Chelsio T4/T5 cards have SR-IOV Capabilities on Physical Functions > > 0..3 and the administrative Driver(cxgb4) attaches to Physical Func= tion 4. > > Each of the Physical Functions 0..3 can support up to 16 Virtual > > Functions. With the current Linux APIs, a 2-Port card would only be > > able to use the Virtual Functions on Physical Functions 0..1 and no= t > > allow the Virtual Functions on Physical Functions 2..3 to be used s= ince > > there are no Ports 2..3 on a 2-Port card. > > > > Also the current ip commands takes netdev as one of the argument, a= nd > > it assumes a 1-to-1 mapping of Network Ports, Physical Functions an= d the > > SR-IOV Virtual Functions of those Physical Functions. But it is not > > true in our case and won't work for us. > >=20 > > Added a new argument to specify the PF number associated with the V= =46, to > > fix this. >=20 > I don't get it - what's the exact definition of 'Physical Function'? > Are we talking PCI functions? Logical partitons? Something else? Its PCIe physical function. Physical functions (PFs) are full-featured PCIe functions; virtual functions (VFs) are =E2=80=9Clightweight=E2=80=9D= functions that lack configuration resource.