netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: christophe.jaillet@wanadoo.fr
Cc: igal.liberman@freescale.com, rdunlap@infradead.org,
	standby24x7@gmail.com, arnd@arndb.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fsl/fman: fix error handling
Date: Mon, 04 Jul 2016 17:18:43 -0700 (PDT)	[thread overview]
Message-ID: <20160704.171843.736302345142812330.davem@davemloft.net> (raw)
In-Reply-To: <1467611202-15168-1-git-send-email-christophe.jaillet@wanadoo.fr>

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Mon,  4 Jul 2016 07:46:42 +0200

> This is likely that checking 'fman->fifo_offset' instead of
> 'fman->cam_offset' is expected here.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> 
> The type of 'fifo_offset' may also need to be changed.

Fix the test rather than trying to force it into the error pointer
macro.

If fifo_offset is not a pointer, then change the test to check for
whatever would be appropriate for values returned from
fman_muram_alloc().

This is a very low quality patch submission, you submitted a "fix"
which added a new build warning and made it obvious that something
else is needed as well here.  You even stated that you realized this.

      reply	other threads:[~2016-07-05  0:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04  5:46 [PATCH] fsl/fman: fix error handling Christophe JAILLET
2016-07-05  0:18 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704.171843.736302345142812330.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arnd@arndb.de \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=igal.liberman@freescale.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).