From: David Miller <davem@redhat.com>
To: brouer@redhat.com
Cc: netdev@vger.kernel.org, rostedt@goodmis.org
Subject: Re: [net-next PATCH] net: tracepoint napi:napi_poll add work and budget
Date: Tue, 05 Jul 2016 11:55:44 -0700 (PDT) [thread overview]
Message-ID: <20160705.115544.1669783693320652521.davem@redhat.com> (raw)
In-Reply-To: <20160705173444.3113.23769.stgit@firesoul>
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Tue, 05 Jul 2016 19:35:27 +0200
> Can this patch go thought the net-next tree?
Sure... when it actually compiles.
If you're changing a fundamental signature like this, it is in your
best interest to do an allmodconfig build... before I do.
net/core/drop_monitor.c: In function ‘set_all_monitor_traces’:
net/core/drop_monitor.c:241:34: warning: passing argument 1 of ‘register_trace_napi_poll’ from incompatible pointer type
rc |= register_trace_napi_poll(trace_napi_poll_hit, NULL);
^
In file included from include/trace/events/skb.h:9:0,
from net/core/drop_monitor.c:31:
include/linux/tracepoint.h:199:2: note: expected ‘void (*)(void *, struct napi_struct *, int, int)’ but argument is of type ‘void (*)(void *, struct napi_struct *)’
register_trace_##name(void (*probe)(data_proto), void *data) \
^
include/linux/tracepoint.h:348:2: note: in expansion of macro ‘__DECLARE_TRACE’
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^
include/linux/tracepoint.h:484:2: note: in expansion of macro ‘DECLARE_TRACE’
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^
include/trace/events/napi.h:13:1: note: in expansion of macro ‘TRACE_EVENT’
TRACE_EVENT(napi_poll,
^
net/core/drop_monitor.c:246:36: warning: passing argument 1 of ‘unregister_trace_napi_poll’ from incompatible pointer type
rc |= unregister_trace_napi_poll(trace_napi_poll_hit, NULL);
^
In file included from include/trace/events/skb.h:9:0,
from net/core/drop_monitor.c:31:
include/linux/tracepoint.h:212:2: note: expected ‘void (*)(void *, struct napi_struct *, int, int)’ but argument is of type ‘void (*)(void *, struct napi_struct *)’
unregister_trace_##name(void (*probe)(data_proto), void *data) \
^
include/linux/tracepoint.h:348:2: note: in expansion of macro ‘__DECLARE_TRACE’
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^
include/linux/tracepoint.h:484:2: note: in expansion of macro ‘DECLARE_TRACE’
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^
include/trace/events/napi.h:13:1: note: in expansion of macro ‘TRACE_EVENT’
TRACE_EVENT(napi_poll,
^
C-c C-cscripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/cavium/liquidio' failed
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/cisco' failed
make[4]: *** [drivers/net/ethernet/cavium/liquidio] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/fddi' failed
make[2]: *** [drivers/net/fddi] Interrupt
make[3]: *** [drivers/net/ethernet/cisco] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/chelsio' failed
make[3]: *** [drivers/net/ethernet/chelsio] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/cavium' failed
make[3]: *** [drivers/net/ethernet/cavium] Interrupt
scripts/Makefile.build:440: recipe for target 'net/wimax' failed
make[1]: *** [net/wimax] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/pci' failed
make[1]: *** [drivers/pci] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet' failed
make[2]: *** [drivers/net/ethernet] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/media/usb/tm6000' failed
make[3]: *** [drivers/media/usb/tm6000] Interrupt
scripts/Makefile.build:295: recipe for target 'net/netfilter/xt_dscp.o' failed
make[2]: *** [net/netfilter/xt_dscp.o] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net' failed
make[1]: *** [drivers/net] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/media/usb' failed
make[2]: *** [drivers/media/usb] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/media' failed
make[1]: *** [drivers/media] Interrupt
Makefile:987: recipe for target 'drivers' failed
make: *** [drivers] Interrupt
scripts/Makefile.build:440: recipe for target 'net/netfilter' failed
make[1]: *** [net/netfilter] Interrupt
Makefile:987: recipe for target 'net' failed
make: *** [net] Interrupt
next prev parent reply other threads:[~2016-07-05 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 17:35 [net-next PATCH] net: tracepoint napi:napi_poll add work and budget Jesper Dangaard Brouer
2016-07-05 18:55 ` David Miller [this message]
2016-07-06 7:19 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705.115544.1669783693320652521.davem@redhat.com \
--to=davem@redhat.com \
--cc=brouer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).