* Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]
@ 2016-07-05 15:35 Sargun Dhillon
2016-07-06 2:16 ` Alexei Starovoitov
0 siblings, 1 reply; 4+ messages in thread
From: Sargun Dhillon @ 2016-07-05 15:35 UTC (permalink / raw)
To: netdev
Does it make sense to backport
3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm
(4.4) release? I can trivially recreate the issue represented by
3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF filter
that clones an ingress ICMP packet, and then tries to set the
destination MAC address.
It seems like the patch applies cleanly to 4.4. I cherry-picked it,
and rebuilt my kernel, and at least in the trivial test case passes.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]
2016-07-05 15:35 Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22] Sargun Dhillon
@ 2016-07-06 2:16 ` Alexei Starovoitov
2016-07-06 3:47 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Alexei Starovoitov @ 2016-07-06 2:16 UTC (permalink / raw)
To: Sargun Dhillon; +Cc: netdev, Daniel Borkmann
On Tue, Jul 05, 2016 at 08:35:18AM -0700, Sargun Dhillon wrote:
> Does it make sense to backport
> 3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm
> (4.4) release? I can trivially recreate the issue represented by
> 3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF filter
> that clones an ingress ICMP packet, and then tries to set the
> destination MAC address.
>
> It seems like the patch applies cleanly to 4.4. I cherry-picked it,
> and rebuilt my kernel, and at least in the trivial test case passes.
Makes sense to me, especially since it's lts.
Daniel, thoughts?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]
2016-07-06 2:16 ` Alexei Starovoitov
@ 2016-07-06 3:47 ` David Miller
2016-07-06 8:12 ` Daniel Borkmann
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2016-07-06 3:47 UTC (permalink / raw)
To: alexei.starovoitov; +Cc: sargun, netdev, daniel
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Tue, 5 Jul 2016 19:16:51 -0700
> On Tue, Jul 05, 2016 at 08:35:18AM -0700, Sargun Dhillon wrote:
>> Does it make sense to backport
>> 3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm
>> (4.4) release? I can trivially recreate the issue represented by
>> 3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF filter
>> that clones an ingress ICMP packet, and then tries to set the
>> destination MAC address.
>>
>> It seems like the patch applies cleanly to 4.4. I cherry-picked it,
>> and rebuilt my kernel, and at least in the trivial test case passes.
>
> Makes sense to me, especially since it's lts.
> Daniel, thoughts?
I'll queued this up for 4.4 -stable.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]
2016-07-06 3:47 ` David Miller
@ 2016-07-06 8:12 ` Daniel Borkmann
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2016-07-06 8:12 UTC (permalink / raw)
To: David Miller, alexei.starovoitov; +Cc: sargun, netdev
On 07/06/2016 05:47 AM, David Miller wrote:
> From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Date: Tue, 5 Jul 2016 19:16:51 -0700
>
>> On Tue, Jul 05, 2016 at 08:35:18AM -0700, Sargun Dhillon wrote:
>>> Does it make sense to backport
>>> 3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm
>>> (4.4) release? I can trivially recreate the issue represented by
>>> 3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF filter
>>> that clones an ingress ICMP packet, and then tries to set the
>>> destination MAC address.
>>>
>>> It seems like the patch applies cleanly to 4.4. I cherry-picked it,
>>> and rebuilt my kernel, and at least in the trivial test case passes.
>>
>> Makes sense to me, especially since it's lts.
>> Daniel, thoughts?
>
> I'll queued this up for 4.4 -stable.
Sounds good, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-06 8:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-05 15:35 Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22] Sargun Dhillon
2016-07-06 2:16 ` Alexei Starovoitov
2016-07-06 3:47 ` David Miller
2016-07-06 8:12 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).