From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, linus.luessing@c0d3.blue,
roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
davem@davemloft.net,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next] net: bridge: extend MLD/IGMP query stats
Date: Wed, 6 Jul 2016 14:31:18 -0700 [thread overview]
Message-ID: <20160706143118.2de2394c@samsung9> (raw)
In-Reply-To: <1467832341-5355-1-git-send-email-nikolay@cumulusnetworks.com>
On Wed, 6 Jul 2016 12:12:21 -0700
Nikolay Aleksandrov <razor@blackwall.org> wrote:
> As was suggested this patch adds support for the different versions of MLD
> and IGMP query types. Since the user visible structure is still in net-next
> we can augment it instead of adding netlink attributes.
> The distinction between the different IGMP/MLD query types is done as
> suggested in Section 7.1, RFC 3376 [1] and Section 8.1, RFC 3810 [2] based
> on query payload size and code for IGMP. Since all IGMP packets go through
> multicast_rcv() and it uses ip_mc_check_igmp/ipv6_mc_check_mld we can be
> sure that at least the ip/ipv6 header can be directly used.
>
> [1] https://tools.ietf.org/html/rfc3376#section-7
> [2] https://tools.ietf.org/html/rfc3810#section-8.1
>
> Suggested-by: Linus Lüssing <linus.luessing@c0d3.blue>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Looks good to me.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
prev parent reply other threads:[~2016-07-06 21:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 19:12 [PATCH net-next] net: bridge: extend MLD/IGMP query stats Nikolay Aleksandrov
2016-07-06 21:31 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706143118.2de2394c@samsung9 \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linus.luessing@c0d3.blue \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).