From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v4 iproute2 0/6] Add support for vrf keyword
Date: Wed, 6 Jul 2016 21:29:23 -0700 [thread overview]
Message-ID: <20160706212923.1a8c5cd7@xeon-e3> (raw)
In-Reply-To: <1467224822-16773-1-git-send-email-dsa@cumulusnetworks.com>
On Wed, 29 Jun 2016 11:26:56 -0700
David Ahern <dsa@cumulusnetworks.com> wrote:
> Currently the syntax for VRF related commands is rather kludgy and
> inconsistent from one subcommand to another. This set adds support
> for the VRF keyword to the link, address, neigh, and route commands
> to improve the user experience listing data associated with vrfs,
> modifying routes or doing a route lookup.
>
> v4
> - Stephen's comments about patch 1 also apply to patch 5, so updated it
> v3
> - addressed comments from Stephen
> - added documentation updates to patches 2, 3 and 6
>
> v2
> - rebased to top of tree
> - all checkpatch warnings are usage lines. The change in these
> patches is consistent with existing code for usage lines
>
> David Ahern (6):
> ip vrf: Add name_is_vrf
> ip link/addr: Add support for vrf keyword
> ip neigh: Add support for keyword
> ip route: Change type mask to bitmask
> ip vrf: Add ipvrf_get_table
> ip route: Add support for vrf keyword
>
> ip/ip_common.h | 3 ++
> ip/ipaddress.c | 12 ++++-
> ip/iplink.c | 15 ++++++-
> ip/iplink_vrf.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++
> ip/ipneigh.c | 14 +++++-
> ip/iproute.c | 43 +++++++++++++++---
> man/man8/ip-address.8.in | 6 +++
> man/man8/ip-link.8.in | 10 +++++
> man/man8/ip-neighbour.8 | 8 +++-
> man/man8/ip-route.8.in | 19 +++++++-
> 10 files changed, 230 insertions(+), 13 deletions(-)
>
Applied, thanks for cleaning it up.
prev parent reply other threads:[~2016-07-07 4:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 18:26 [PATCH v4 iproute2 0/6] Add support for vrf keyword David Ahern
2016-06-29 18:26 ` [PATCH v4 iproute2 1/6] ip vrf: Add name_is_vrf David Ahern
2016-06-29 18:26 ` [PATCH v4 iproute2 2/6] ip link/addr: Add support for vrf keyword David Ahern
2016-06-29 18:26 ` [PATCH v4 iproute2 3/6] ip neigh: Add support for keyword David Ahern
2016-06-29 18:27 ` [PATCH v4 iproute2 4/6] ip route: Change type mask to bitmask David Ahern
2016-06-29 18:27 ` [PATCH v4 iproute2 5/6] ip vrf: Add ipvrf_get_table David Ahern
2016-06-29 18:27 ` [PATCH v4 iproute2 6/6] ip route: Add support for vrf keyword David Ahern
2016-07-07 4:29 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706212923.1a8c5cd7@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).