From: Wei Liu <wei.liu2@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>,
<xen-devel@lists.xenproject.org>, <netdev@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()
Date: Thu, 7 Jul 2016 11:35:13 +0100 [thread overview]
Message-ID: <20160707103513.GB416@citrix.com> (raw)
In-Reply-To: <577E27B8.2050603@citrix.com>
On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote:
> On 07/07/16 08:57, Jan Beulich wrote:
> > Only a positive return value indicates success.
>
> This is not correct.
>
Do you mean the commit message is not correct or the code is not
correct? If it is the formal, do you have any suggestion to fix it?
(I was going to just ack this because Paul already reviewed it)
Wei.
> David
next prev parent reply other threads:[~2016-07-07 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:57 [PATCH] xen-netback: correct return value checks on xenbus_scanf() Jan Beulich
2016-07-07 8:26 ` [Xen-devel] " Paul Durrant
2016-07-07 9:58 ` David Vrabel
2016-07-07 10:35 ` Wei Liu [this message]
2016-07-07 10:40 ` Paul Durrant
2016-07-07 10:42 ` Paul Durrant
2016-07-07 10:45 ` David Vrabel
2016-07-07 10:55 ` Paul Durrant
2016-07-07 12:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707103513.GB416@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).