Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Olaf Hering <olaf@aepfle.de>
To: Dexuan Cui <decui@microsoft.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"joe@perches.com" <joe@perches.com>,
	Rolf Neugebauer <rolf.neugebauer@docker.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"apw@canonical.com" <apw@canonical.com>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
Date: Thu, 7 Jul 2016 18:02:06 +0200	[thread overview]
Message-ID: <20160707160206.GA5279@aepfle.de> (raw)
In-Reply-To: <CY1PR03MB21865E21E637F03877784979BF240@CY1PR03MB2186.namprd03.prod.outlook.com>

[-- Attachment #1.1: Type: text/plain, Size: 1228 bytes --]

On Thu, Jun 30, Dexuan Cui wrote:

> +/* The MTU is 16KB per the host side's design. */
> +struct hvsock_recv_buf {
> +	unsigned int data_len;
> +	unsigned int data_offset;
> +
> +	struct vmpipe_proto_header hdr;
> +	u8 buf[PAGE_SIZE * 4];

Please use some macro related to the protocol rather than a Linux
compiletime macro.

> +/* We send at most 4KB payload per VMBus packet. */
> +struct hvsock_send_buf {
> +	struct vmpipe_proto_header hdr;
> +	u8 buf[PAGE_SIZE];

Same here.

> + * Copyright(c) 2016, Microsoft Corporation. All rights reserved.

Here the BSD license follows. I think its required/desired to also
include a GPL blurb like it is done in many other files:
...
 * Alternatively, this software may be distributed under the terms of
 * the GNU General Public License ("GPL") version 2 as published by the
 * Free Software Foundation.
....

Otherwise the MODULE_LICENSE string might be incorrect.

> +	/* Hyper-V Sockets requires at least VMBus 4.0 */
> +	if ((vmbus_proto_version >> 16) < 4) {
> +		pr_err("failed to load: VMBus 4 or later is required\n");

I guess this mens WS 2016+, and loading in earlier host versions will
trigger this path? I think a silent ENODEV is enough.

> +		return -ENODEV;

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel