netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Gavin Shan <gwshan@linux.vnet.ibm.com>,
	Linux Netdev List <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	joel@jms.id.au, weixue@trustnetic.com,
	Yuval Itkin <yuvali@mellanox.com>
Subject: Re: [PATCH net-next 00/10] NCSI Support
Date: Fri, 8 Jul 2016 02:34:22 +1000	[thread overview]
Message-ID: <20160707163422.GA28500@gwshan> (raw)
In-Reply-To: <CAJ3xEMg_gCT4rE=U3uX5tjqRarCLukKT9K2iFjsrk_7gwmwNHA@mail.gmail.com>

On Thu, Jul 07, 2016 at 04:44:02PM +0300, Or Gerlitz wrote:
>On Thu, Jul 7, 2016 at 12:17 PM, Benjamin Herrenschmidt
><benh@kernel.crashing.org> wrote:
>> On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote:
>>> On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov
>>> <alexei.starovoitov@gmail.com> wrote:
>>> > On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote:
>>>
>>> > Or, since cx4 has ncsi as well, could you do a thorough review of this
>>> > to make sure that it fits mellanox nics as well?
>>>
>>> Hi Alexei, all
>>>
>>> Yuval from our team who deals with host management did review on the
>>> series, SB his feedback.
>>>
>>> 1. The initialization uses a single unicast MAC address which hints it
>>> assumes that the management traffic is IPv4 only. The infrastructure
>>> does not seem to be ready for IPv6 based management traffic.
>>
>> You mean the transfer of the MAC address from the BMC to the NIC for
>> filtering incoming traffic ?
>
>The initialization sequence uses "Set MAC Command" once and
>initializes MAC[1] in the chosen NC-SI pass-through channel.
>If IPv6 is used, then the BMC multicast address (derived from the
>assigned IP address to the BMC) shall also be configured (after the IP
>address is assigned), and some multicast filtering shall be set as
>well.
>

Or, Thanks for the explanation. I think they are the multicast
MAC addresses (33:33:00:00:00:01/02/03)? I guess sending a Global
Multicast Filter Command is enough according to the NCSI spec
(line 2062 on page 93):

The Enable Global Multicast Filter command is used to activate global
filtering of multicast frames with optional filtering of specific multicast
protocols. Upon receiving and processing this command, the channel shall only
deliver multicast frames that match specific multicast MAC addresses enabled
for Pass through using this command ___or___ the Set MAC Address command.

Thanks,
Gavin

  reply	other threads:[~2016-07-07 16:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03  5:32 [PATCH net-next 00/10] NCSI Support Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 01/10] net/ncsi: Resource management Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 02/10] net/ncsi: NCSI command packet handler Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 03/10] net/ncsi: NCSI response " Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 04/10] net/ncsi: Package and channel management Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 05/10] net/ncsi: NCSI AEN packet handler Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 06/10] net/farady: Helper functions to create or destroy MDIO interface Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 07/10] net/farady: Read MAC address from chip Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 08/10] net/farady: Support NCSI mode Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 09/10] net/farady: Match driver according to compatible property Gavin Shan
2016-07-03  5:32 ` [PATCH net-next 10/10] net/farady: Mask PHY interrupt with NCSI mode Gavin Shan
2016-07-03 22:03 ` [PATCH net-next 00/10] NCSI Support Or Gerlitz
2016-07-03 22:49   ` Benjamin Herrenschmidt
2016-07-04  0:24     ` Gavin Shan
2016-07-05 17:44   ` Alexei Starovoitov
2016-07-05 21:42     ` Benjamin Herrenschmidt
2016-07-06  2:07       ` Alexei Starovoitov
2016-07-06  2:14         ` Benjamin Herrenschmidt
2016-07-07  9:12     ` Or Gerlitz
2016-07-07  9:17       ` Benjamin Herrenschmidt
2016-07-07  9:18         ` Benjamin Herrenschmidt
2016-07-07 13:05         ` Gavin Shan
2016-07-07 13:44         ` Or Gerlitz
2016-07-07 16:34           ` Gavin Shan [this message]
2016-07-07 17:32 ` Florian Fainelli
2016-07-07 22:05   ` Benjamin Herrenschmidt
2016-07-08  1:10   ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160707163422.GA28500@gwshan \
    --to=gwshan@linux.vnet.ibm.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=gerlitz.or@gmail.com \
    --cc=joel@jms.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=weixue@trustnetic.com \
    --cc=yuvali@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).