From: Florian Westphal <fw@strlen.de>
To: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Cc: Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
shmulik.ladkani@gmail.com, netdev@vger.kernel.org,
Alexander Duyck <alexander.duyck@gmail.com>,
Tom Herbert <tom@herbertland.com>
Subject: Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs
Date: Mon, 11 Jul 2016 10:15:11 +0200 [thread overview]
Message-ID: <20160711081511.GG2067@breakpoint.cc> (raw)
In-Reply-To: <20160710105120.72d80371@pixies>
Shmulik Ladkani <shmulik.ladkani@ravellosystems.com> wrote:
> OK with the general idea; However I don't want to abuse IPSKB_FORWARDED
> as the skb is not really "ip forwarded", and it might have undesirable
> affects, such as in 'ip_skb_dst_mtu' which follows.
I don't see a problem with that. Hannes?
next prev parent reply other threads:[~2016-07-11 8:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 12:35 [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs Shmulik Ladkani
2016-07-05 13:03 ` Florian Westphal
2016-07-05 14:05 ` Shmulik Ladkani
2016-07-09 3:12 ` David Miller
2016-07-09 9:06 ` Florian Westphal
2016-07-09 9:00 ` Florian Westphal
2016-07-09 12:30 ` Shmulik Ladkani
2016-07-09 13:22 ` Florian Westphal
2016-07-10 7:51 ` Shmulik Ladkani
2016-07-11 8:15 ` Florian Westphal [this message]
2016-07-11 13:32 ` Hannes Frederic Sowa
2016-07-12 5:56 ` Shmulik Ladkani
2016-07-13 14:00 ` Shmulik Ladkani
2016-07-14 13:12 ` Hannes Frederic Sowa
2016-07-14 14:13 ` Shmulik Ladkani
2016-07-14 23:32 ` Hannes Frederic Sowa
2016-07-10 20:14 ` Shmulik Ladkani
2016-07-11 8:13 ` Florian Westphal
2016-07-09 15:10 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711081511.GG2067@breakpoint.cc \
--to=fw@strlen.de \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=shmulik.ladkani@ravellosystems.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).