From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brenden Blanco Subject: Re: [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding Date: Mon, 11 Jul 2016 15:06:33 -0700 Message-ID: <20160711220632.GD22729@gmail.com> References: <1468272598-21390-1-git-send-email-bblanco@plumgrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , Linux Netdev List , Jamal Hadi Salim , Saeed Mahameed , Martin KaFai Lau , Jesper Dangaard Brouer , Ari Saha , Alexei Starovoitov , john fastabend , Hannes Frederic Sowa , Thomas Graf , Tom Herbert , Daniel Borkmann To: Or Gerlitz Return-path: Received: from mail-pa0-f48.google.com ([209.85.220.48]:35948 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbcGKWGh (ORCPT ); Mon, 11 Jul 2016 18:06:37 -0400 Received: by mail-pa0-f48.google.com with SMTP id hu1so26197003pad.3 for ; Mon, 11 Jul 2016 15:06:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jul 12, 2016 at 12:53:34AM +0300, Or Gerlitz wrote: > On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco wrote: > > > v7: > [...] > > TODOs: > > Add ethtool per-ring stats for aborted, default cases, maybe even drop > > and tx as well. > > please no... lets stop and think if we can have something better vs > every XDP enabled driver to have bunch of new ethtool based stats, was > this somehow discussed over the threads so far? This was in the context of the discussion in [01/12] relating to the return codes and debuggability.