From: Brenden Blanco <bblanco@plumgrid.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
saeedm@dev.mellanox.co.il, kafai@fb.com, brouer@redhat.com,
as754m@att.com, alexei.starovoitov@gmail.com,
gerlitz.or@gmail.com, john.fastabend@gmail.com,
hannes@stressinduktion.org, tgraf@suug.ch, tom@herbertland.com,
daniel@iogearbox.net
Subject: Re: [PATCH v7 01/11] bpf: add XDP prog type for early driver filter
Date: Mon, 11 Jul 2016 23:26:14 -0700 [thread overview]
Message-ID: <20160712062613.GA20499@gmail.com> (raw)
In-Reply-To: <20160711.230254.53567533766522969.davem@davemloft.net>
On Mon, Jul 11, 2016 at 11:02:54PM -0700, David Miller wrote:
> From: Brenden Blanco <bblanco@plumgrid.com>
> Date: Mon, 11 Jul 2016 14:29:48 -0700
>
> > + WARN_ONCE(1, "\n"
> > + "*****************************************************\n"
> > + "** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"
> > + "** **\n"
> > + "** XDP program returned unknown value %-10u **\n"
> > + "** **\n"
> > + "** XDP programs must return a well-known return **\n"
> > + "** value. Invalid return values will result in **\n"
> > + "** packet loss. **\n"
> > + "** **\n"
> > + "** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"
> > + "*****************************************************\n",
>
> This is rediculous.
>
> The log message should be concise, one line, and not scream things
> like "NOTICE". That's what the log level is for, to indicate the
> severity of the issue.
Makes sense, and I won't try this approach again. The caller of this
code continues to be much debated as well.
next prev parent reply other threads:[~2016-07-12 6:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 21:29 [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 01/11] bpf: add XDP prog type for early driver filter Brenden Blanco
2016-07-12 6:02 ` David Miller
2016-07-12 6:26 ` Brenden Blanco [this message]
2016-07-11 21:29 ` [PATCH v7 02/11] net: add ndo to setup/query xdp prog in adapter rx Brenden Blanco
2016-07-12 6:12 ` David Miller
2016-07-12 6:35 ` Brenden Blanco
2016-07-12 6:45 ` David Miller
2016-07-11 21:29 ` [PATCH v7 03/11] rtnl: add option for setting link xdp prog Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf program Brenden Blanco
2016-07-12 6:17 ` David Miller
2016-07-12 16:31 ` Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 05/11] Add sample for adding simple drop program to link Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 07/11] bpf: add XDP_TX xdp_action for direct forwarding Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 08/11] net/mlx4_en: break out tx_desc write into separate function Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 09/11] net/mlx4_en: add xdp forwarding and data write support Brenden Blanco
2016-07-13 15:25 ` Saeed Mahameed
2016-07-13 17:30 ` Brenden Blanco
2016-07-13 19:16 ` Saeed Mahameed
2016-07-11 21:29 ` [PATCH v7 10/11] bpf: enable direct packet data write for xdp progs Brenden Blanco
2016-07-11 21:29 ` [PATCH v7 11/11] bpf: add sample for xdp forwarding and rewrite Brenden Blanco
2016-07-11 21:53 ` [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding Or Gerlitz
2016-07-11 22:06 ` Brenden Blanco
2016-07-11 23:26 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712062613.GA20499@gmail.com \
--to=bblanco@plumgrid.com \
--cc=alexei.starovoitov@gmail.com \
--cc=as754m@att.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).