* [PATCH -next] net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe()
@ 2016-07-13 12:46 weiyj_lk
2016-07-14 1:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2016-07-13 12:46 UTC (permalink / raw)
To: David S . Miller; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/broadcom/bgmac-platform.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c
index 1a2d841..be52f27 100644
--- a/drivers/net/ethernet/broadcom/bgmac-platform.c
+++ b/drivers/net/ethernet/broadcom/bgmac-platform.c
@@ -129,10 +129,8 @@ static int bgmac_probe(struct platform_device *pdev)
}
bgmac->plat.base = devm_ioremap_resource(&pdev->dev, regs);
- if (IS_ERR(bgmac->plat.base)) {
- dev_err(&pdev->dev, "Unable to map base resource\n");
+ if (IS_ERR(bgmac->plat.base))
return PTR_ERR(bgmac->plat.base);
- }
regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "idm_base");
if (!regs) {
@@ -141,10 +139,8 @@ static int bgmac_probe(struct platform_device *pdev)
}
bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
- if (IS_ERR(bgmac->plat.idm_base)) {
- dev_err(&pdev->dev, "Unable to map idm resource\n");
+ if (IS_ERR(bgmac->plat.idm_base))
return PTR_ERR(bgmac->plat.idm_base);
- }
bgmac->read = platform_bgmac_read;
bgmac->write = platform_bgmac_write;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe()
2016-07-13 12:46 [PATCH -next] net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe() weiyj_lk
@ 2016-07-14 1:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-07-14 1:08 UTC (permalink / raw)
To: weiyj_lk; +Cc: yongjun_wei, netdev
From: weiyj_lk@163.com
Date: Wed, 13 Jul 2016 12:46:57 +0000
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-14 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-13 12:46 [PATCH -next] net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe() weiyj_lk
2016-07-14 1:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).