From: David Miller <davem@davemloft.net>
To: bgalvani@redhat.com
Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com,
gospo@cumulusnetworks.com, kernel@linuxace.com
Subject: Re: [PATCH] bonding: set carrier off for devices created through netlink
Date: Thu, 14 Jul 2016 16:18:30 -0700 (PDT) [thread overview]
Message-ID: <20160714.161830.432143369745656151.davem@davemloft.net> (raw)
In-Reply-To: <1468427108-32516-1-git-send-email-bgalvani@redhat.com>
From: Beniamino Galvani <bgalvani@redhat.com>
Date: Wed, 13 Jul 2016 18:25:08 +0200
> Commit e826eafa65c6 ("bonding: Call netif_carrier_off after
> register_netdevice") moved netif_carrier_off() from bond_init() to
> bond_create(), but the latter is called only for initial default
> devices and ones created through sysfs:
>
> $ modprobe bonding
> $ echo +bond1 > /sys/class/net/bonding_masters
> $ ip link add bond2 type bond
> $ grep "MII Status" /proc/net/bonding/*
> /proc/net/bonding/bond0:MII Status: down
> /proc/net/bonding/bond1:MII Status: down
> /proc/net/bonding/bond2:MII Status: up
>
> Ensure that carrier is initially off also for devices created through
> netlink.
>
> Signed-off-by: Beniamino Galvani <bgalvani@redhat.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-07-14 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 16:25 [PATCH] bonding: set carrier off for devices created through netlink Beniamino Galvani
2016-07-14 23:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714.161830.432143369745656151.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bgalvani@redhat.com \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=kernel@linuxace.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).