From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: christophe.jaillet@wanadoo.fr, jiri@mellanox.com,
idosch@mellanox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error
Date: Thu, 14 Jul 2016 22:15:11 -0700 (PDT) [thread overview]
Message-ID: <20160714.221511.31164307170492201.davem@davemloft.net> (raw)
In-Reply-To: <20160714062819.GB2228@nanopsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 14 Jul 2016 08:28:19 +0200
> Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jaillet@wanadoo.fr wrote:
>>'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong.
>>Return an explicit error code (-ENOENT) instead.
>>
>
> This is fo net-next.
>
> Fixes: 61c503f976 ("mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops")
>
>>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
Applied, thanks.
prev parent reply other threads:[~2016-07-15 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:18 [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error Christophe JAILLET
2016-07-14 6:28 ` Jiri Pirko
2016-07-15 5:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714.221511.31164307170492201.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).