From: Leon Romanovsky <leonro@mellanox.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Matan Barak <matanb@mellanox.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()
Date: Thu, 14 Jul 2016 23:09:38 +0300 [thread overview]
Message-ID: <20160714200938.GB30603@leon.nu> (raw)
In-Reply-To: <24af412f-7fa5-fa2e-c605-21ea5d45f5ff@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Wed, Jul 13, 2016 at 02:40:26PM +0300, Or Gerlitz wrote:
> On 7/13/2016 2:19 PM, Matan Barak wrote:
> >I'm not sure EINVAL is the right error here though.
> >Maybe -ENOTSUPP is a bit more appropriate here.
>
> I agree, Dan, can you please change to be along Matan's suggestion?
Or,
Dan already did it before Matan's response and we have very vivid discussion about it [1].
[1] http://marc.info/?t=146841063000002&r=1&w=2
>
> Or.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-14 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 10:08 [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table() Dan Carpenter
2016-07-13 11:19 ` Matan Barak
2016-07-13 11:40 ` Or Gerlitz
2016-07-14 20:09 ` Leon Romanovsky [this message]
2016-07-13 11:29 ` Leon Romanovsky
2016-07-13 11:53 ` [patch v2] " Matan Barak
2016-07-13 13:04 ` Leon Romanovsky
[not found] ` <20160713130459.GF10079-2ukJVAZIZ/Y@public.gmane.org>
2016-07-13 13:17 ` Matan Barak
2016-07-13 17:54 ` Jason Gunthorpe
2016-07-14 5:56 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714200938.GB30603@leon.nu \
--to=leonro@mellanox.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).