From: David Miller <davem@davemloft.net>
To: tremyfr@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, manuel.lauss@gmail.com,
mugunthanvnm@ti.com, ivecera@redhat.com, xypron.glpk@gmx.de,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: amd: au1000_eth: use phy_ethtool_{get|set}_link_ksettings
Date: Fri, 15 Jul 2016 16:44:13 -0700 (PDT) [thread overview]
Message-ID: <20160715.164413.2171292428501556413.davem@davemloft.net> (raw)
In-Reply-To: <1468577112-7884-2-git-send-email-tremyfr@gmail.com>
From: Philippe Reynes <tremyfr@gmail.com>
Date: Fri, 15 Jul 2016 12:05:12 +0200
> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
>
> There was a check on CAP_NET_ADMIN in au1000_set_settings, but this
> check is already done in dev_ethtool, so no need to repeat it before
> calling the generic function.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
next prev parent reply other threads:[~2016-07-15 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 10:05 [PATCH 1/2] net: ethernet: amd: au1000_eth: use phydev from struct net_device Philippe Reynes
2016-07-15 10:05 ` [PATCH 2/2] net: ethernet: amd: au1000_eth: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-07-15 23:44 ` David Miller [this message]
2016-07-15 23:44 ` [PATCH 1/2] net: ethernet: amd: au1000_eth: use phydev from struct net_device David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715.164413.2171292428501556413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=ivecera@redhat.com \
--cc=manuel.lauss@gmail.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).