From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, mark.einon@gmail.com, andrew@lunn.ch,
a@unstable.cc, felipe.balbi@linux.intel.com, fw@strlen.de,
wuninsu@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] et131x: Fix logical vs bitwise check in et131x_tx_timeout()
Date: Sat, 16 Jul 2016 22:04:44 -0700 (PDT) [thread overview]
Message-ID: <20160716.220444.1385583329528724015.davem@davemloft.net> (raw)
In-Reply-To: <1468626024-31534-1-git-send-email-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 15 Jul 2016 16:40:22 -0700
> We should be using a logical check here instead of a bitwise operation
> to check if the device is closed already in et131x_tx_timeout().
>
> Reported-by: coverity (CID 146498)
> Fixes: 38df6492eb511 ("et131x: Add PCIe gigabit ethernet driver et131x to drivers/net")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
prev parent reply other threads:[~2016-07-17 5:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 23:40 [PATCH net] et131x: Fix logical vs bitwise check in et131x_tx_timeout() Florian Fainelli
2016-07-17 5:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716.220444.1385583329528724015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a@unstable.cc \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wuninsu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).