From: Andrew Lunn <andrew@lunn.ch>
To: Charles-Antoine Couret <charles-antoine.couret@nexvision.fr>
Cc: cacouret.renault@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] Marvell phy: check link status in case of fiber link.
Date: Mon, 18 Jul 2016 17:32:57 +0200 [thread overview]
Message-ID: <20160718153257.GJ19265@lunn.ch> (raw)
In-Reply-To: <1468832623-1792-2-git-send-email-charles-antoine.couret@nexvision.fr>
On Mon, Jul 18, 2016 at 11:03:40AM +0200, Charles-Antoine Couret wrote:
Hi Charles-Antoine
Looking good. Just one nitpick.
> /* marvell_read_status
You missed changing this name above.
> *
> - * Generic status code does not detect Fiber correctly!
> * Description:
> * Check the link, then figure out the current state
> * by comparing what we advertise with what the link partner
> * advertises. Start by checking the gigabit possibilities,
> * then move on to 10/100.
> */
> -static int marvell_read_status(struct phy_device *phydev)
> +static int marvell_read_status_page(struct phy_device *phydev, int page)
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2016-07-18 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 9:03 [PATCH v5 0/4] Marvell phy: manage fiber link for some phys Charles-Antoine Couret
2016-07-18 9:03 ` [PATCH 1/4] Marvell phy: check link status in case of fiber link Charles-Antoine Couret
2016-07-18 15:32 ` Andrew Lunn [this message]
2016-07-18 9:03 ` [PATCH 2/4] Marvell phy: add field to get errors from " Charles-Antoine Couret
2016-07-18 15:33 ` Andrew Lunn
2016-07-18 9:03 ` [PATCH 3/4] Marvell phy: add configuration of autonegociation for " Charles-Antoine Couret
2016-07-18 15:36 ` Andrew Lunn
2016-07-18 9:03 ` [PATCH 4/4] Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links Charles-Antoine Couret
2016-07-18 15:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718153257.GJ19265@lunn.ch \
--to=andrew@lunn.ch \
--cc=cacouret.renault@gmail.com \
--cc=charles-antoine.couret@nexvision.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).