From: Brenden Blanco <bblanco@plumgrid.com>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Jamal Hadi Salim <jhs@mojatatu.com>,
Saeed Mahameed <saeedm@dev.mellanox.co.il>,
Martin KaFai Lau <kafai@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Ari Saha <as754m@att.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Or Gerlitz <gerlitz.or@gmail.com>,
john.fastabend@gmail.com, hannes@stressinduktion.org,
Thomas Graf <tgraf@suug.ch>, Tom Herbert <tom@herbertland.com>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH v9 00/11] Add driver bpf hook for early packet drop and forwarding
Date: Mon, 18 Jul 2016 10:16:37 -0700 [thread overview]
Message-ID: <20160718171635.GB29243@gmail.com> (raw)
In-Reply-To: <20160718163827.GA29243@gmail.com>
On Mon, Jul 18, 2016 at 09:38:28AM -0700, Brenden Blanco wrote:
> On Mon, Jul 18, 2016 at 04:39:38PM +0300, Tariq Toukan wrote:
> > After applying the patchset, I get no ping between two VLAN
> > interfaces (w/o activating any BPF program).
> > I'm debugging it, and will update once I find the bug.
> >
> > Brenden, please check if you can repro the issue.
> I was able to reproduce it also. I suspect a bug in patch 8/11.
I clearly didn't test vlans, sorry for that! The fix is pretty obvious, see
below if you want to double check. I will fix up 8/11 in the next iteration.
> >
> > Regards,
> > Tariq
> >
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 5d8452d..9df87ca 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -833,7 +831,7 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev)
bf_ok = ring->bf_enabled;
if (skb_vlan_tag_present(skb)) {
- qpn_vlan.vlan_tag = skb_vlan_tag_get(skb);
+ qpn_vlan.vlan_tag = cpu_to_be16(skb_vlan_tag_get(skb));
vlan_proto = be16_to_cpu(skb->vlan_proto);
if (vlan_proto == ETH_P_8021AD)
qpn_vlan.ins_vlan = MLX4_WQE_CTRL_INS_SVLAN;
prev parent reply other threads:[~2016-07-18 17:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 23:28 [PATCH v9 00/11] Add driver bpf hook for early packet drop and forwarding Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 01/11] bpf: add XDP prog type for early driver filter Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 02/11] net: add ndo to setup/query xdp prog in adapter rx Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 03/11] rtnl: add option for setting link xdp prog Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 04/11] net/mlx4_en: add support for fast rx drop bpf program Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 05/11] Add sample for adding simple drop program to link Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 07/11] bpf: add XDP_TX xdp_action for direct forwarding Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 08/11] net/mlx4_en: break out tx_desc write into separate function Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 09/11] net/mlx4_en: add xdp forwarding and data write support Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 10/11] bpf: enable direct packet data write for xdp progs Brenden Blanco
2016-07-15 23:28 ` [PATCH v9 11/11] bpf: add sample for xdp forwarding and rewrite Brenden Blanco
2016-07-18 13:39 ` [PATCH v9 00/11] Add driver bpf hook for early packet drop and forwarding Tariq Toukan
2016-07-18 16:38 ` Brenden Blanco
2016-07-18 17:16 ` Brenden Blanco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718171635.GB29243@gmail.com \
--to=bblanco@plumgrid.com \
--cc=alexei.starovoitov@gmail.com \
--cc=as754m@att.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).