* [PATCH net] net: switchdev: change ageing_time type to clock_t
@ 2016-07-18 19:02 Vivien Didelot
2016-07-19 23:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vivien Didelot @ 2016-07-18 19:02 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, kernel, David S. Miller, Jiri Pirko, Scott Feldman,
Ido Schimmel, Florian Fainelli, Andrew Lunn, Vivien Didelot
The switchdev value for the SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME
attribute is a clock_t and requires to use helpers such as
clock_t_to_jiffies() to convert to milliseconds.
Change ageing_time type from u32 to clock_t to make it explicit.
Fixes: f55ac58ae64c ("switchdev: add bridge ageing_time attribute")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
include/net/switchdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 9023e3e..62f6a96 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -60,7 +60,7 @@ struct switchdev_attr {
struct netdev_phys_item_id ppid; /* PORT_PARENT_ID */
u8 stp_state; /* PORT_STP_STATE */
unsigned long brport_flags; /* PORT_BRIDGE_FLAGS */
- u32 ageing_time; /* BRIDGE_AGEING_TIME */
+ clock_t ageing_time; /* BRIDGE_AGEING_TIME */
bool vlan_filtering; /* BRIDGE_VLAN_FILTERING */
} u;
};
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net: switchdev: change ageing_time type to clock_t
2016-07-18 19:02 [PATCH net] net: switchdev: change ageing_time type to clock_t Vivien Didelot
@ 2016-07-19 23:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-07-19 23:49 UTC (permalink / raw)
To: vivien.didelot
Cc: netdev, linux-kernel, kernel, jiri, sfeldma, idosch, f.fainelli,
andrew
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Mon, 18 Jul 2016 15:02:06 -0400
> The switchdev value for the SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME
> attribute is a clock_t and requires to use helpers such as
> clock_t_to_jiffies() to convert to milliseconds.
>
> Change ageing_time type from u32 to clock_t to make it explicit.
>
> Fixes: f55ac58ae64c ("switchdev: add bridge ageing_time attribute")
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-19 23:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-18 19:02 [PATCH net] net: switchdev: change ageing_time type to clock_t Vivien Didelot
2016-07-19 23:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).