From: David Miller <davem@davemloft.net>
To: yeshaswi@chelsio.com
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
jlulla@chelsio.ccom, harsh@chelsio.com, atul.gupta@chelsio.com,
herbert@gondor.apana.org.au
Subject: Re: [Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware
Date: Tue, 19 Jul 2016 21:15:22 -0700 (PDT) [thread overview]
Message-ID: <20160719.211522.465417746785662817.davem@davemloft.net> (raw)
In-Reply-To: <1468906935-6770-3-git-send-email-yeshaswi@chelsio.com>
From: Yeshaswi M R Gowda <yeshaswi@chelsio.com>
Date: Mon, 18 Jul 2016 22:42:14 -0700
> +config CRYPTO_DEV_CHELSIO
> + tristate "Chelsio Crypto Co-processor Driver"
> + depends on PCI && NETDEVICES && ETHERNET
> + select CRYPTO_SHA1
> + select CRYPTO_SHA256
> + select CRYPTO_SHA512
> + select NET_VENDOR_CHELSIO
> + select CHELSIO_T4
The user shouldn't have to know about the technical details about
how this chip is physically implemented.
It's therefore not reasonable to require an ethernet driver to be
enabled to use the crypto engine.
Also, selecting Kconfig symbol X does not recursively enable the
"select" statement(s) of symbol X nor does it check symbol X's
dependencies.
This is really one big huge dependency mess, and I think you have
to split out the core of the T4 driver into a driver subtype
agnostic library or similar to make this work properly.
Don't just shoehorn this stuff into the ethernet driver. Round
peg, square hole.
next prev parent reply other threads:[~2016-07-20 4:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 5:42 [Patch-V2 0/3] crypto/chcr: Add Chelsio Crypto Driver Yeshaswi M R Gowda
2016-07-19 5:42 ` [Patch-V2 1/3] cxgb4: Add Chelsio LLD support Chelsio Crypto ULD Yeshaswi M R Gowda
2016-07-19 5:42 ` [Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware Yeshaswi M R Gowda
2016-07-20 4:15 ` David Miller [this message]
2016-08-17 5:51 ` Hariprasad Shenai
2016-07-19 5:42 ` [Patch-V2 3/3] crypto: Added Chelsio Menu to the Kconfig file Yeshaswi M R Gowda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719.211522.465417746785662817.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atul.gupta@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=harsh@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=jlulla@chelsio.ccom \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yeshaswi@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).