* [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()
@ 2016-07-19 11:33 Wei Yongjun
2016-07-19 11:37 ` Måns Rullgård
2016-07-20 21:48 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-07-19 11:33 UTC (permalink / raw)
To: f.fainelli, davem, mans, tremyfr, arnd, sf84; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In ops->reset() error handling case, clk_disable_unprepare() is missed
before return from this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/aurora/nb8800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 2dcb8c7..0d4ea92 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1419,7 +1419,7 @@ static int nb8800_probe(struct platform_device *pdev)
if (ops && ops->reset) {
ret = ops->reset(dev);
if (ret)
- goto err_free_dev;
+ goto err_disable_clk;
}
bus = devm_mdiobus_alloc(&pdev->dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()
2016-07-19 11:33 [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe() Wei Yongjun
@ 2016-07-19 11:37 ` Måns Rullgård
2016-07-20 21:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Måns Rullgård @ 2016-07-19 11:37 UTC (permalink / raw)
To: Wei Yongjun; +Cc: f.fainelli, davem, tremyfr, arnd, sf84, Wei Yongjun, netdev
Wei Yongjun <weiyj_lk@163.com> writes:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In ops->reset() error handling case, clk_disable_unprepare() is missed
> before return from this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/net/ethernet/aurora/nb8800.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 2dcb8c7..0d4ea92 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1419,7 +1419,7 @@ static int nb8800_probe(struct platform_device *pdev)
> if (ops && ops->reset) {
> ret = ops->reset(dev);
> if (ret)
> - goto err_free_dev;
> + goto err_disable_clk;
> }
>
> bus = devm_mdiobus_alloc(&pdev->dev);
>
--
Måns Rullgård
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()
2016-07-19 11:33 [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe() Wei Yongjun
2016-07-19 11:37 ` Måns Rullgård
@ 2016-07-20 21:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-07-20 21:48 UTC (permalink / raw)
To: weiyj_lk; +Cc: f.fainelli, mans, tremyfr, arnd, sf84, yongjun_wei, netdev
From: Wei Yongjun <weiyj_lk@163.com>
Date: Tue, 19 Jul 2016 11:33:10 +0000
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In ops->reset() error handling case, clk_disable_unprepare() is missed
> before return from this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-20 21:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-19 11:33 [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe() Wei Yongjun
2016-07-19 11:37 ` Måns Rullgård
2016-07-20 21:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).