From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Matthew Finlay <matt@mellanox.com>
Subject: Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset
Date: Wed, 20 Jul 2016 17:53:55 -0700 [thread overview]
Message-ID: <20160721005350.GB85017@ast-mbp> (raw)
In-Reply-To: <1469050793-29235-1-git-send-email-saeedm@mellanox.com>
On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote:
> memset the command buffers rather than the pointers to them.
that is still wrong commit log.
This patch makes zero difference to generated code.
'&in' is the same as 'in'
> Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling")
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> ---
>
> V2:
> - Improved log message.
>
> drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
> index 05de772..e25a73ed 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
> @@ -72,8 +72,8 @@ static int mlx5e_vxlan_core_del_port_cmd(struct mlx5_core_dev *mdev, u16 port)
> u32 in[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_in)];
> u32 out[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_out)];
>
> - memset(&in, 0, sizeof(in));
> - memset(&out, 0, sizeof(out));
> + memset(in, 0, sizeof(in));
> + memset(out, 0, sizeof(out));
>
> MLX5_SET(delete_vxlan_udp_dport_in, in, opcode,
> MLX5_CMD_OP_DELETE_VXLAN_UDP_DPORT);
> --
> 2.8.0
>
next prev parent reply other threads:[~2016-07-21 0:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 21:39 [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset Saeed Mahameed
2016-07-20 22:30 ` David Miller
2016-07-21 0:53 ` Alexei Starovoitov [this message]
2016-07-21 8:08 ` Saeed Mahameed
2016-07-21 17:48 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721005350.GB85017@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=matt@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox