From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>,
netdev@vger.kernel.org, davem@davemloft.net,
benh@kernel.crashing.org, David.Laight@ACULAB.COM
Subject: Re: [PATCH net-next v2] net/faraday: Disallow using reversed MAC address from hardware
Date: Fri, 22 Jul 2016 10:01:48 +1000 [thread overview]
Message-ID: <20160722000148.GA5176@gwshan> (raw)
In-Reply-To: <20160721140109.GM11309@lunn.ch>
On Thu, Jul 21, 2016 at 04:01:09PM +0200, Andrew Lunn wrote:
>On Thu, Jul 21, 2016 at 11:42:54AM +1000, Gavin Shan wrote:
>> The initial MAC address is retrieved from hardware if it's not
>> provided by device-tree. The reserved MAC address from hardware
>> will be used if non-reserved MAC address is invalid. It will
>> cause mismatched MAC address seen by hardware and software.
>>
>> This disallows using the reserved hardware MAC address to avoid
>> the mismatched MAC address seen by hardware and software.
>>
>> Fixes: 113ce107afe9 ("net/faraday: Read MAC address from chip")
>> Suggested-by: David Laight <David.Laight@ACULAB.COM>
>> Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>
>Too late now, since it has been accepted, but the subject line says
>reversed, not reserved.
>
Yes, It should be reversed, not reserved in the commit log.
Thanks,
Gavin
prev parent reply other threads:[~2016-07-22 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 1:42 [PATCH net-next v2] net/faraday: Disallow using reversed MAC address from hardware Gavin Shan
2016-07-21 4:05 ` David Miller
2016-07-21 14:01 ` Andrew Lunn
2016-07-22 0:01 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722000148.GA5176@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=David.Laight@ACULAB.COM \
--cc=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox