* [PATCH] net: bridge: fix br_stp_enable_bridge comment
@ 2016-07-21 16:42 Vivien Didelot
2016-07-25 17:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vivien Didelot @ 2016-07-21 16:42 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, kernel, David S. Miller, Stephen Hemminger,
Vivien Didelot
br_stp_enable_bridge() does take the br->lock spinlock. Fix its wrongly
pasted comment and use the same as br_stp_disable_bridge().
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
net/bridge/br_stp_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
index 984d462..341caa0 100644
--- a/net/bridge/br_stp_if.c
+++ b/net/bridge/br_stp_if.c
@@ -55,7 +55,7 @@ void br_init_port(struct net_bridge_port *p)
netdev_err(p->dev, "failed to set HW ageing time\n");
}
-/* called under bridge lock */
+/* NO locks held */
void br_stp_enable_bridge(struct net_bridge *br)
{
struct net_bridge_port *p;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: bridge: fix br_stp_enable_bridge comment
2016-07-21 16:42 [PATCH] net: bridge: fix br_stp_enable_bridge comment Vivien Didelot
@ 2016-07-25 17:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-07-25 17:31 UTC (permalink / raw)
To: vivien.didelot; +Cc: netdev, linux-kernel, kernel, stephen
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Thu, 21 Jul 2016 12:42:10 -0400
> br_stp_enable_bridge() does take the br->lock spinlock. Fix its wrongly
> pasted comment and use the same as br_stp_disable_bridge().
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-25 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-21 16:42 [PATCH] net: bridge: fix br_stp_enable_bridge comment Vivien Didelot
2016-07-25 17:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).