From: David Miller <davem@davemloft.net>
To: u.kleine-koenig@pengutronix.de
Cc: mugunthanvnm@ti.com, grygorii.strashko@ti.com,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log
Date: Mon, 25 Jul 2016 17:57:05 -0700 (PDT) [thread overview]
Message-ID: <20160725.175705.820422537273157170.davem@davemloft.net> (raw)
In-Reply-To: <1469440485-19889-1-git-send-email-u.kleine-koenig@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Mon, 25 Jul 2016 11:54:45 +0200
> Such a big dump of register values is hardly useful on a production
> system.
>
> Another downside of the now removed functions is that calling
> emac_dump_regs resulted in at least 87 calls to dev_info while holding a
> spinlock and having irqs off which is a big source of latency.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied.
next prev parent reply other threads:[~2016-07-26 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 9:54 [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log Uwe Kleine-König
2016-07-26 0:57 ` David Miller [this message]
2016-07-26 14:09 ` Grygorii Strashko
2016-07-26 14:26 ` Grygorii Strashko
2016-07-26 22:06 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725.175705.820422537273157170.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).