netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: decui@microsoft.com
Cc: mkubecek@suse.cz, olaf@aepfle.de, gregkh@linuxfoundation.org,
	jasowang@redhat.com, dave.scott@docker.com,
	linux-kernel@vger.kernel.org, joe@perches.com,
	rolf.neugebauer@docker.com, netdev@vger.kernel.org,
	apw@canonical.com, devel@linuxdriverproject.org,
	haiyangz@microsoft.com
Subject: Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets
Date: Mon, 25 Jul 2016 21:38:22 -0700 (PDT)	[thread overview]
Message-ID: <20160725.213822.1745865660912873332.davem@davemloft.net> (raw)
In-Reply-To: <CO2PR03MB2182D011056AA151CCEF4EFFBF0E0@CO2PR03MB2182.namprd03.prod.outlook.com>

From: Dexuan Cui <decui@microsoft.com>
Date: Tue, 26 Jul 2016 03:09:16 +0000

> BTW, during the past month, at least 7 other people also reviewed
> the patch and gave me quite a few good comments, which have
> been addressed.

Correction: Several people gave coding style and simple corrections
to your patch.

Very few gave any review of the _SUBSTANCE_ of your changes.

And the one of the few who did, and suggested you build your
facilities using the existing S390 hypervisor socket infrastructure,
you brushed off _IMMEDIATELY_.

That drives me crazy.  The one person who gave you real feedback
you basically didn't consider seriously at all.

I know why you don't want to consider alternative implementations,
and it's because you guys have so much invested in what you've
implemented already.

But that's tough and not our problem.

And until this changes, yes, this submission will be stuck in the
mud and continue slogging on like this.

Sorry.

  reply	other threads:[~2016-07-26  4:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-23  1:35 [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets Dexuan Cui
2016-07-26  0:37 ` David Miller
2016-07-26  3:09   ` Dexuan Cui
2016-07-26  4:38     ` David Miller [this message]
2016-07-26  5:10       ` Dexuan Cui
2016-07-26  7:09         ` Dexuan Cui
2016-07-26  9:56           ` Michal Kubecek
2016-07-26 13:22             ` Dexuan Cui
2016-07-27  9:20               ` Dexuan Cui
2016-07-26 17:44           ` David Miller
2016-07-27  9:20             ` Dexuan Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160725.213822.1745865660912873332.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=apw@canonical.com \
    --cc=dave.scott@docker.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=rolf.neugebauer@docker.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).